On Thu, Nov 07, 2019 at 11:33:06PM -0800, Christoph Hellwig wrote: > On Thu, Nov 07, 2019 at 11:29:51PM -0800, Darrick J. Wong wrote: > > That said, "Is this cursor pointing to the last block on $level?" only > > makes sense if you've already performed a lookup (or seek) operation. > > If you've done that, you've already checked the block, right? So I > > think we could just get rid of the _check_block call on the grounds that > > we already did that as part of the lookup (or turn it into an ASSERT), > > and then this becomes a short enough function to try to make it a four > > line static inline predicate. > > > > Same result, but slightly better encapsulation. > > > > (Yeah yeah, it's C, we're all one big happy family of bits...) > > Sounds ok. Ok, I'll push out a (lightly tested) patch. --D
