On Thu, Nov 07, 2019 at 12:35:47PM +0100, Pavel Reichl wrote: > Signed-off-by: Pavel Reichl <preichl@xxxxxxxxxx> > --- > fs/xfs/xfs_qm.c | 14 +++++++------- > fs/xfs/xfs_qm.h | 4 ++-- > fs/xfs/xfs_trans_dquot.c | 2 +- > 3 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c > index a8b278348f5a..4088273adb11 100644 > --- a/fs/xfs/xfs_qm.c > +++ b/fs/xfs/xfs_qm.c > @@ -32,7 +32,7 @@ > STATIC int xfs_qm_init_quotainos(xfs_mount_t *); > STATIC int xfs_qm_init_quotainfo(xfs_mount_t *); > > -STATIC void xfs_qm_destroy_quotainos(xfs_quotainfo_t *qi); > +STATIC void xfs_qm_destroy_quotainos(struct xfs_quotainfo *qi); > STATIC void xfs_qm_dqfree_one(struct xfs_dquot *dqp); > /* > * We use the batch lookup interface to iterate over the dquots as it > @@ -539,9 +539,9 @@ xfs_qm_shrink_count( > > STATIC void > xfs_qm_set_defquota( > - xfs_mount_t *mp, > - uint type, > - xfs_quotainfo_t *qinf) > + xfs_mount_t *mp, Please de-typedef this while you're touching the lines. Otherwise looks good! --D > + uint type, > + struct xfs_quotainfo *qinf) > { > struct xfs_dquot *dqp; > struct xfs_def_quota *defq; > @@ -642,7 +642,7 @@ xfs_qm_init_quotainfo( > > ASSERT(XFS_IS_QUOTA_RUNNING(mp)); > > - qinf = mp->m_quotainfo = kmem_zalloc(sizeof(xfs_quotainfo_t), 0); > + qinf = mp->m_quotainfo = kmem_zalloc(sizeof(struct xfs_quotainfo), 0); > > error = list_lru_init(&qinf->qi_lru); > if (error) > @@ -711,7 +711,7 @@ void > xfs_qm_destroy_quotainfo( > xfs_mount_t *mp) > { > - xfs_quotainfo_t *qi; > + struct xfs_quotainfo *qi; > > qi = mp->m_quotainfo; > ASSERT(qi != NULL); > @@ -1559,7 +1559,7 @@ xfs_qm_init_quotainos( > > STATIC void > xfs_qm_destroy_quotainos( > - xfs_quotainfo_t *qi) > + struct xfs_quotainfo *qi) > { > if (qi->qi_uquotaip) { > xfs_irele(qi->qi_uquotaip); > diff --git a/fs/xfs/xfs_qm.h b/fs/xfs/xfs_qm.h > index b41b75089548..185c9d89a5cd 100644 > --- a/fs/xfs/xfs_qm.h > +++ b/fs/xfs/xfs_qm.h > @@ -54,7 +54,7 @@ struct xfs_def_quota { > * Various quota information for individual filesystems. > * The mount structure keeps a pointer to this. > */ > -typedef struct xfs_quotainfo { > +struct xfs_quotainfo { > struct radix_tree_root qi_uquota_tree; > struct radix_tree_root qi_gquota_tree; > struct radix_tree_root qi_pquota_tree; > @@ -77,7 +77,7 @@ typedef struct xfs_quotainfo { > struct xfs_def_quota qi_grp_default; > struct xfs_def_quota qi_prj_default; > struct shrinker qi_shrinker; > -} xfs_quotainfo_t; > +}; > > static inline struct radix_tree_root * > xfs_dquot_tree( > diff --git a/fs/xfs/xfs_trans_dquot.c b/fs/xfs/xfs_trans_dquot.c > index ceb25d1cfdb1..4789f7e11f53 100644 > --- a/fs/xfs/xfs_trans_dquot.c > +++ b/fs/xfs/xfs_trans_dquot.c > @@ -585,7 +585,7 @@ xfs_trans_dqresv( > xfs_qwarncnt_t warnlimit; > xfs_qcnt_t total_count; > xfs_qcnt_t *resbcountp; > - xfs_quotainfo_t *q = mp->m_quotainfo; > + struct xfs_quotainfo *q = mp->m_quotainfo; > struct xfs_def_quota *defq; > > > -- > 2.23.0 >