On Thu, Nov 7, 2019 at 4:37 PM Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote: > I'll fix it on commit. Thanks. So now the one remaining issue I have with those two functions is why we check for (offset > size) instead of (offset >= size) in if (page->mapping != inode->i_mapping || offset > size) When (offset == size), we're clearly outside the page, and so we should fail? Thanks, Andreas