On Wed, Nov 06, 2019 at 05:05:55PM -0800, Darrick J. Wong wrote: > > > +} > > > + > > > +void > > > +xfs_dir2_sf_put_ino( > > Also, I think these helpers can be static now... xfs_dir2_sf_put_ino can and should be marked static. xfs_dir2_sf_get_ino is used elsewhere, though.