Re: [PATCH 3/3] xfs_scrub: adapt phase5 to deferred descriptions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/22/19 1:49 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Apply the deferred description mechanism to phase 5 so that we don't
> build inode prefix strings unless we actually want to say something
> about an inode's attributes or directory entries.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
...

> @@ -232,18 +246,17 @@ xfs_scrub_connections(
>  	void			*arg)
>  {
>  	bool			*pmoveon = arg;
> -	char			descr[DESCR_BUFSZ];
> +	DEFINE_DESCR(dsc, ctx, render_ino_from_handle);


I don't really love the DEFINE_DESCR macro, now that I already acked the last
patch, but if I really care i'll send a patch of my own. ;)

but looks ok, so

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux