On 06/11/2019 15:56, Darrick J. Wong wrote:
> On Wed, Nov 06, 2019 at 03:52:48PM +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> Variable error is being initialized with a value that is never read
>> and is being re-assigned a couple of statements later on. The
>> assignment is redundant and hence can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>
> Er... is there a coverity id that goes with this?
Unfortunately it is a private one, so it does not make sense to use it.
>
> Patch looks fine otherwise.
>
> --D
>
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>> ---
>> fs/xfs/xfs_super.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
>> index b3188ea49413..2302f67d1a18 100644
>> --- a/fs/xfs/xfs_super.c
>> +++ b/fs/xfs/xfs_super.c
>> @@ -1362,7 +1362,7 @@ xfs_fc_fill_super(
>> {
>> struct xfs_mount *mp = sb->s_fs_info;
>> struct inode *root;
>> - int flags = 0, error = -ENOMEM;
>> + int flags = 0, error;
>>
>> mp->m_super = sb;
>>
>> --
>> 2.20.1
>>
