On Tue, Nov 05, 2019 at 02:52:54AM +0100, Christoph Hellwig wrote: > On Mon, Nov 04, 2019 at 12:25:23PM -0800, Darrick J. Wong wrote: > > On Fri, Nov 01, 2019 at 03:06:59PM -0700, Christoph Hellwig wrote: > > > Return the xfs_dir3_icfree_hdr used by the helpers called from > > > xfs_dir2_node_addname_int to the main function to prepare for the > > > next round of changes. > > > > How does this help? Is this purely to reduce stack usage? Or will we > > use this later to skip some xfs_dir2_free_hdr_from_disk calls? > > The latter. Might be a good idea at least to hint at that in the commit message. --D