On Tue, Nov 05, 2019 at 02:42:15AM +0100, Christoph Hellwig wrote:
> On Mon, Nov 04, 2019 at 12:07:44PM -0800, Darrick J. Wong wrote:
> > > diff --git a/fs/xfs/libxfs/xfs_da_btree.h b/fs/xfs/libxfs/xfs_da_btree.h
> > > index 5e3e954fee77..c8b137685ca7 100644
> > > --- a/fs/xfs/libxfs/xfs_da_btree.h
> > > +++ b/fs/xfs/libxfs/xfs_da_btree.h
> > > @@ -27,6 +27,7 @@ struct xfs_da_geometry {
> > > int magicpct; /* 37% of block size in bytes */
> > > xfs_dablk_t datablk; /* blockno of dir data v2 */
> > > int leaf_hdr_size; /* dir2 leaf header size */
> > > + unsigned int leaf_max_ents; /* # of entries in dir2 leaf */
> >
> > Why does this one get 'unsigned' but the header size fields don't?
> > Or maybe I should rephase that: Why aren't the header sizes unsigned
> > too?
>
> They probably should all be unsigned and I should add a prep patch
> for the existing ones.
Sounds good!
--D
