On Mon, Nov 04, 2019 at 10:36:18AM -0800, Darrick J. Wong wrote: > Seeing as this function returns a pointer to struct xfs_attr_leaf_entry, > why not clean this up to: > > ent = xfs_attr3_leaf_entryp(...)[blk->index]; ? Well, it should really be xfs_attr3_leaf_entryp + blk->index. But otherwise agreed and fixed up for the next version.