On Fri, Nov 01, 2019 at 03:51:27PM +0800, Ian Kent wrote: > Grouping the options parsing and mount handling functions above the > struct fs_context_operations but below the struct super_operations > should improve (some) the grouping of the super operations while also > improving the grouping of the options parsing and mount handling code. > > Lastly move xfs_fc_parse_param() and related functions down to above > xfs_fc_get_tree() and it's related functions. > > But leave the options enum, struct fs_parameter_spec and the struct > fs_parameter_description declarations at the top since that's the > logical place for them. > > Signed-off-by: Ian Kent <raven@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>