> +static int
> +xfs_fc_reconfigure(
> + struct fs_context *fc)
> {
> - struct xfs_mount *mp = XFS_M(sb);
> + struct xfs_mount *mp = XFS_M(fc->root->d_sb);
Nit: please align the argument to the same level as the local variables
below
> + sync_filesystem(mp->m_super);
> +
> + error = xfs_fc_validate_params(new_mp);
> if (error)
> return error;
> - sync_filesystem(sb);
I don't think there is any good reason to call sync_filesystem if
the validation failed.
> +static void xfs_fc_free(struct fs_context *fc)
This should use the normal XFS prototype style.
> +static int xfs_init_fs_context(struct fs_context *fc)
Same here.
Btw, I think we can just fold xfs_mount_alloc into xfs_init_fs_context
now.
Except for these nitpicks this looks fine to me now.
