On Tue, Oct 29, 2019 at 06:03:42AM -0400, Brian Foster wrote: > On Tue, Oct 29, 2019 at 03:41:33PM +1100, Dave Chinner wrote: > > FWIW, I find something like the following a bit more clear/concise on > the whole: > > /* > + * Once AIO and DIO has drained we flush and (if necessary) invalidate > + * the cached range over the first operation we are about to run. We > + * include zero and collapse here because they both start with a hole > + * punch over the target range. Insert and collapse both invalidate the > + * broader range affected by the shift in xfs_prepare_shift(). > */ Yup, much better. Thanks! :) Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
