On Tue, Oct 29, 2019 at 12:16:15AM -0700, Christoph Hellwig wrote: > On Fri, Oct 25, 2019 at 09:04:48AM -0700, Darrick J. Wong wrote: > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > > > > > Note that we can remove the check for '/' from xfs_dir2_namecheck for > > > currentl mainline, given that verify_dirent_name in common code now has > > > that check. > > > > We can't, because this is the same function that xfs_repair uses to > > decide if a directory entry is garbage. > > So we'll at least need to document that for now. And maybe find a way > to not do the work twice eventually in a way that doesn't break repair. What if we promote EFSCORRUPTED and EFSBADCRC to the vfs (since 5 filesystems use them now); change the VFS check function to return that; and then we can just drop the xfs readdir calls to dir2_namecheck? --D
