On Mon, Oct 28, 2019 at 09:06:38AM -0700, Darrick J. Wong wrote: > Why does it make more sense to do the inode extsize roundup only for > direct writes and not as an intermediate step of determining the > speculative preallocation size than what the code does now? No behavior change in this patch. xfs_buffered_write_iomap_begin already passes a 0 extsize to xfs_eof_alignment, making the code moved from xfs_eof_alignment to xfs_iomap_eof_align_last_fsb a no-op for the buffered write path.