On 10/25/19 12:40 PM, Christoph Hellwig wrote: > The m_readio_log is only used for reporting the blksize (aka preferred > I/O size) in struct stat. For all cases but a file system that does not > use stripe alignment, but which has the wsync and largeio mount option > set the value is the same as the write I/O size. > > Remove the field and report a smaller preferred I/O size for that corner > case, which actually is the right thing to do for that case (except for > the fact that is probably is entirely unused). hm, I wonder what the history of the WSYNC_ sizes are, tbh. So while I can't speak to the need for a separate READIO_LOG or not, this doesn't seem too far fetched... If Dave remembers something about NFS behavior, he can nak my rvb :) Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
