Re: [PATCH 08/11] xfs_scrub: fix media verification thread pool size calculations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/25/19 4:36 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> The read verifier pool deals with two different thread counts -- there's
> the submitter thread count that enables us to perform per-thread verify
> request aggregation, and then there's the io thread pool count which is
> the maximum number of IO requests we want to send to the disk at any
> given time.
> 
> The io thread pool count should be derived from disk_heads() but instead
> we bungle it by measuring and modifying(!) the nproc global variable.
> Fix the derivation to use global variables correctly.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Seems like I'd noticed this before but can't remember now. :) Anyway,

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux