On Wed, Oct 16, 2019 at 09:53:30PM -0700, Darrick J. Wong wrote: > > The problem is that this will probably be used in logging later and > > there's a lot of logging that uses the upper case variant. > > > > OTOH if all the log messages were changed to use lower case "xfs" then > > one of the problems I see with logging (that name inconsistency) would > > go away. > > > > So I'm not sure what I should do here. > > I would just leave it 'XFS' for consistency, but I might be in the back > pocket of Big Letter. ;) I isn't really used for much, and Al already has a patch from Eric in on of his trees that kills the field in favor of the file_system_type name field: https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/commit/?h=work.mount-parser-later&id=543fdf1d617edd6d681fcc50e16478e832a7a2ac So we should not spell them differently if we can.