On Wed, Oct 16, 2019 at 08:41:38AM +0800, Ian Kent wrote: > +static int > +xfs_validate_params( > + struct xfs_mount *mp, > + int dsunit, > + int dswidth, > + uint8_t iosizelog, > + bool nooptions) Please add a refactor patch before this one to always set the stripe unit / width / log I/O size values in the mount structure at parsing time as suggested before. The will also remove the need for the xfs_fs_context structure in the last patch. > + if (nooptions) > + goto noopts; This option is always false in this patch. I'd suggest you only add it once we actually add a user.
