On Wed, Oct 16, 2019 at 08:41:32AM +0800, Ian Kent wrote: > Refactor xfs_parseags(), move the entire token case block to a > separate function in an attempt to highlight the code that > actually changes in converting to use the new mount api. > > The only changes are what's needed to communicate the variables > dsunit, dswidth and iosizelog back to xfs_parseags(). Use up the full space avaiable for commit log, please. > + case Opt_gqnoenforce: > + mp->m_qflags |= (XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE); > + mp->m_qflags &= ~XFS_GQUOTA_ENFD; > + break; > + case Opt_discard: > + mp->m_flags |= XFS_MOUNT_DISCARD; > + break; > + case Opt_nodiscard: > + mp->m_flags &= ~XFS_MOUNT_DISCARD; > + break; > +#ifdef CONFIG_FS_DAX > + case Opt_dax: > + mp->m_flags |= XFS_MOUNT_DAX; > + break; > +#endif > + default: > + xfs_warn(mp, "unknown mount option [%s].", p); > + return -EINVAL; > + } > + > + return 0; It seems all these breaks could simply directly do a return 0, make the function a tidbit easier to read. > + ret = xfs_parse_param(token, p, args, mp, > + &dsunit, &dswidth, &iosizelog); Please use up the full 80 chars on the first line
