Re: [PATCH v6 06/12] xfs: add xfs_remount_rw() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v6 06/12] xfs: add xfs_remount_rw() helper
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 16 Oct 2019 01:30:22 -0700
Cc: linux-xfs <linux-xfs@xxxxxxxxxxxxxxx>, Brian Foster <bfoster@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>
In-reply-to: <157118647366.9678.14061368527967040009.stgit@fedora-28>
References: <157118625324.9678.16275725173770634823.stgit@fedora-28> <157118647366.9678.14061368527967040009.stgit@fedora-28>
User-agent: Mutt/1.12.1 (2019-06-15)

> +	xfs_sb_t		*sbp = &mp->m_sb;

Please use the underlying struct types instead of the typedefs for all
new/modified code.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v6 00/12] xfs: mount API patch series
  - From: Ian Kent
- [PATCH v6 06/12] xfs: add xfs_remount_rw() helper
  - From: Ian Kent

Prev by Date: Re: [PATCH v6 05/12] xfs: dont use XFS_IS_QUOTA_RUNNING() for option check
Next by Date: Re: [PATCH v6 07/12] xfs: add xfs_remount_ro() helper
Previous by thread: [PATCH v6 06/12] xfs: add xfs_remount_rw() helper
Next by thread: Re: [PATCH v6 06/12] xfs: add xfs_remount_rw() helper
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]

Powered by Linux