On 10/15/19 11:16 AM, Matthew Wilcox wrote: > On Tue, Oct 15, 2019 at 08:52:24AM -0700, Christoph Hellwig wrote: >> On Tue, Oct 15, 2019 at 10:39:36AM -0500, Eric Sandeen wrote: >>> iomap_page_create() initializes the uptodate bitmap using the SECTOR_SIZE >>> macro, so use that in the definition as well, for consistency and safety. >>> >>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> >>> --- >>> >>> Last time there was a concern about pulling in blkdev.h just for this, >>> but that's already been done now, so try again. >> >> Note that the iomap writepage series, which is hopefully about to be >> merged moves this declaration around. > > ... and the support-multiple-page-sizes patches make it dynamically > allocated ;-) > *sigh* obviously I'm not keeping up. Thanks, -Eric