Re: [PATCH] xfs: change the seconds fields in xfs_bulkstat to signed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 15, 2019 at 01:02:30AM -0700, Christoph Hellwig wrote:
> On Mon, Oct 14, 2019 at 10:12:11AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > 
> > 64-bit time is a signed quantity in the kernel, so the bulkstat
> > structure should reflect that.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Strictly speaking this is a break of the userspace API, but I can't see
> how it causes problems in practice, so:

Yeah, I think I'll add a note to the changelog:

"Note that the structure size stays the same and that we have not yet
published userspace headers for this new ioctl so there are no users to
break."

> Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux