Re: [PATCH] xfs: change the seconds fields in xfs_bulkstat to signed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 14, 2019 at 10:12:11AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> 64-bit time is a signed quantity in the kernel, so the bulkstat
> structure should reflect that.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>

> ---
>  fs/xfs/libxfs/xfs_fs.h |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_fs.h b/fs/xfs/libxfs/xfs_fs.h
> index b0c884e80915..8b77eace70f1 100644
> --- a/fs/xfs/libxfs/xfs_fs.h
> +++ b/fs/xfs/libxfs/xfs_fs.h
> @@ -368,11 +368,11 @@ struct xfs_bulkstat {
>  	uint64_t	bs_blocks;	/* number of blocks		*/
>  	uint64_t	bs_xflags;	/* extended flags		*/
>  
> -	uint64_t	bs_atime;	/* access time, seconds		*/
> -	uint64_t	bs_mtime;	/* modify time, seconds		*/
> +	int64_t		bs_atime;	/* access time, seconds		*/
> +	int64_t		bs_mtime;	/* modify time, seconds		*/
>  
> -	uint64_t	bs_ctime;	/* inode change time, seconds	*/
> -	uint64_t	bs_btime;	/* creation time, seconds	*/
> +	int64_t		bs_ctime;	/* inode change time, seconds	*/
> +	int64_t		bs_btime;	/* creation time, seconds	*/
>  
>  	uint32_t	bs_gen;		/* generation count		*/
>  	uint32_t	bs_uid;		/* user id			*/

-- 
Carlos



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux