On Wed, Oct 09, 2019 at 04:27:45PM +0200, Christoph Hellwig wrote: > XFSERRORDEBUG is never set and the code isn't all that useful, so remove > it. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > --- > fs/xfs/xfs_log.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c > index 67a767d90ebf..7a429e5dc27c 100644 > --- a/fs/xfs/xfs_log.c > +++ b/fs/xfs/xfs_log.c > @@ -3996,19 +3996,6 @@ xfs_log_force_umount( > spin_unlock(&log->l_cilp->xc_push_lock); > xlog_state_do_callback(log, true, NULL); > > -#ifdef XFSERRORDEBUG > - { > - xlog_in_core_t *iclog; > - > - spin_lock(&log->l_icloglock); > - iclog = log->l_iclog; > - do { > - ASSERT(iclog->ic_callback == 0); > - iclog = iclog->ic_next; > - } while (iclog != log->l_iclog); > - spin_unlock(&log->l_icloglock); > - } > -#endif > /* return non-zero if log IOERROR transition had already happened */ > return retval; > } > -- > 2.20.1 >