Hi Christoph,
On Wed, 2019-10-09 at 07:48 -0700, Christoph Hellwig wrote:
> On Wed, Oct 09, 2019 at 07:30:31PM +0800, Ian Kent wrote:
> > +static const struct fs_parameter_spec xfs_param_specs[] = {
> > + fsparam_u32 ("logbufs", Opt_logbufs), /* number of XFS
> > log buffers */
> > + fsparam_string ("logbsize", Opt_logbsize), /* size of XFS log
> > buffers */
>
> This has really weird indentation, and a couple overly long lines
> below.
> I'm also not really sure the comments are all that useful here vs in
> the actual parser.
>
> Why not:
>
> static const struct fs_parameter_spec xfs_param_specs[] = {
> fsparam_u32("logbufs", Opt_logbufs),
> fsparam_string("logbsize", Opt_logbsize),
> ..
> };
>
> ?
The indentation is purely an effort to preserve the comments.
I originally interleaved them in the structure declaration but
that was even uglier and naturally attracted comments.
I can't remember now if there was a specific request to preserve
the comments.
You suggestion is to add these comments to the case handling in
xfs_parse_param(), correct?
I can do that if there are no other suggestions.
Ian
