Re: [PATCH v5 05/17] xfs: mount-api - refactor suffix_kstrtoint()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 09, 2019 at 05:03:10PM +0100, Al Viro wrote:
> Except that I want to be able to have something like
> -       fsparam_enum   ("errors",             Opt_errors),
> +       fsparam_enum   ("errors",             Opt_errors, gfs2_param_errors),
> with
> +static const struct fs_parameter_enum gfs2_param_errors[] = {
> +       {"withdraw",   Opt_errors_withdraw },
> +       {"panic",      Opt_errors_panic },
> +       {}
> +};
> instead of having them all squashed into one array, as in

Makes total sense and still fits the above scheme.

> IOW, I want to kill ->enums thing.  And ->name is also trivial
> to kill, at which point we are left with just what used to be
> ->specs.

Agreed.

> I have some experiments in that direction (very incomplete right
> now) in #work.mount-parser-later; next cycle fodder, I'm afraid.

I like that a lot, and feel like we really shouldn't do more
conversions until that ground work has been done



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux