On Wed, Oct 09, 2019 at 07:31:35PM +0800, Ian Kent wrote: > The infrastructure needed to use the new mount api is now > in place, switch over to use it. I find it weird that you add the methods and params table first and think the series would be a lot easier to understand if you just did independent refatoring first and then a big switch over. > +/* > + * Set up the filesystem mount context. > + */ Not exactly a very helpful comment, after all it is a method instance.. > +int xfs_init_fs_context(struct fs_context *fc) This should be static. Btw, for most of the STATICs in the series we'd just use static these days as well. And at least for method instances STATIC actually never made any sense..
