On Wed, Oct 09, 2019 at 07:30:58PM +0800, Ian Kent wrote: > Much of the code in xfs_fs_fill_super() will be used by the fill super > function of the new mount-api. > > So refactor the common code into a helper in an attempt to show what's > actually changed. I hate how this ends up leaving a pointless helper around. If you really absolutely want to add the helper here please also remove it again at the end of the series.