On Wed, Oct 09, 2019 at 07:30:42PM +0800, Ian Kent wrote: > Refactor xfs_parseags(), move the entire token case block to a > separate function in an attempt to highlight the code that > actually changes in converting to use the new mount api. > > The only changes are what's needed to communicate the variables > dsunit, dswidth and iosizelog back to xfs_parseags(). I think with just a little refactoring we can communicate those through the mount structure, where we eventually asign them. That will just need a little extra code to clear m_dalign and m_swidth in the XFS_MOUNT_NOALIGN case. > +#ifdef CONFIG_FS_DAX > + case Opt_dax: > + mp->m_flags |= XFS_MOUNT_DAX; > + break; > +#endif This can be cleaned up a bit using IS_ENABLED().