Hi all, Here's v2 of the directory inode shortform to block logging fixup. This also addresses the similar attr fork conversion function. I put the other cleanups into separate patches because it wasn't totally clear to me if we wanted to add the log call to the conversion function given the other callers log the inode outside of that function. IOW, we can either keep or drop patch 3. I have no strong preference either way. Brian v2: - Also fix up attr fork conversion. - Add patches 2 and 3 for follow up cleanups. v1: https://lore.kernel.org/linux-xfs/20191004125520.7857-1-bfoster@xxxxxxxxxx/ Brian Foster (3): xfs: log the inode on directory sf to block format change xfs: remove broken error handling on failed attr sf to leaf change xfs: move local to extent inode logging into bmap helper fs/xfs/libxfs/xfs_attr_leaf.c | 21 +++------------------ fs/xfs/libxfs/xfs_bmap.c | 6 ++++-- fs/xfs/libxfs/xfs_bmap.h | 3 ++- fs/xfs/libxfs/xfs_dir2_block.c | 2 +- 4 files changed, 10 insertions(+), 22 deletions(-) -- 2.20.1