On Mon, Sep 30, 2019 at 08:17:01AM -0400, Brian Foster wrote: > The active flag was in the allocation cursor originally and was moved to > the private portion of the btree cursor simply because IIRC that's where > you suggested to put it. My memory starts fading, but IIRC you had a separate containing structure and I asked to move it into xfs_btree_cur itself. > FWIW, that seems like the appropriate place to > me because 1.) as of right now I don't have any other use case in mind > outside of allocbt cursors 2.) flag state is similarly managed in the > allocation btree helpers and 3.) the flag is not necessarily used as a > generic btree cursor state (it is more accurately a superset of the > generic btree state where the allocation algorithm can also make higher > level changes). The latter bit is why it was originally put in the > allocation tracking structure, FWIW. Ok, sounds fine with me for now. I just feels like doing it in the generic code would actually be simpler than updating all the wrappers.
