On 9/30/19 2:29 PM, Darrick J. Wong wrote: > On Mon, Sep 30, 2019 at 02:23:40PM -0500, Eric Sandeen wrote: >> On 9/25/19 4:33 PM, Darrick J. Wong wrote: >>> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >>> >>> Convert all the workqueue functions to return positive error codes so >>> that we can move away from the libc-style indirect errno handling and >>> towards passing error codes directly back to callers. >> >> This all looks fine, but it doesn't really do what the commit log says, >> right? > > Urrrk... yes. Clearly I stamped out the changelogs with a machine. :/ > > I /think/ most of the patches in that series actually have a return > conversion and a callsite conversion, but this one clearly is just... > > "Convert workqueue functions to return errno errors from the C library, > then convert the callers to use str_liberror to report the runtime > error." > >> The one spot where error return is changed, it was already >> positive; the rest is swapping str_liberror for str_info which is >> just cosmetic, right? > > <shrug> Mostly cosmetic. Before you'd get: > > INFO: Could not create workqueue > > Now you get: > > ERROR: creating icount workqueue: Not enough frobs. > > (and it actually records it as a runtime error :P) Yup, ok - I'll just edit the changelog for you. -Eric
