On 9/26/19 11:18 PM, Darrick J. Wong wrote:
>>> +
>>> + inumbers_cmd.args =
>>> + _("[-a agno] [-d] [-e endino] [-n batchsize] [-s startino]");
>> <missing the -v option>
>>
>>> + inumbers_cmd.oneline = _("Query inode groups in a filesystem");
>> I'm confused, why aren't all these ^^^ just in the structure definitions?
> All of these ... what? I'm confused, sorry.
>
I'm wondering why these 2 fields get set up in bulkstat_init(), vs at
cmdinfo_t structure definition time, i.e.
static cmdinfo_t inumbers_cmd = {
.name = "inumbers",
.cfunc = inumbers_f,
.argmin = 0,
.argmax = -1,
.flags = CMD_NOMAP_OK | CMD_FLAG_ONESHOT,
.args =
_("[-a agno] [-d] [-e endino] [-n batchsize] [-s startino] [-v version]");
.oneline = _("Query inode groups in a filesystem");
.help = inumbers_help,
};
like ~every other command does?
-Eric
