On Mon, Sep 30, 2019 at 12:54:41AM -0700, Christoph Hellwig wrote: > On Wed, Sep 25, 2019 at 02:40:38PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Convert libfrog functions to return negative error codes like libxfs > > does. > > Looks fine, although in the places where you touch the whole switch > statement I wonder why we just switch those to negative errnos instead > of inverting and then checking for positive values.. This series only converts libfrog functions and callsites. Next I'll start converting utilities one by one, but there are already too many patches out so I'm holding off until that after a series or two get merged. > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks for the review! --D
