Re: [PATCH] xfs: remove unused flags arg from xfs_get_aghdr_buf()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 27, 2019 at 10:46:42AM -0500, Eric Sandeen wrote:
> The flags op is always passed as zero, so remove it.

Fixing the  op -> arg:

Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>


> 
> (xfs_buf_get_uncached takes flags to support XBF_NO_IOACCT for
> the sb, but that should never be relevant for xfs_get_aghdr_buf)

> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> diff --git a/fs/xfs/libxfs/xfs_ag.c b/fs/xfs/libxfs/xfs_ag.c
> index 5de296b34ab1..14fbdf22b7e7 100644
> --- a/fs/xfs/libxfs/xfs_ag.c
> +++ b/fs/xfs/libxfs/xfs_ag.c
> @@ -28,12 +28,11 @@ xfs_get_aghdr_buf(
>  	struct xfs_mount	*mp,
>  	xfs_daddr_t		blkno,
>  	size_t			numblks,
> -	int			flags,
>  	const struct xfs_buf_ops *ops)
>  {
>  	struct xfs_buf		*bp;
>  
> -	bp = xfs_buf_get_uncached(mp->m_ddev_targp, numblks, flags);
> +	bp = xfs_buf_get_uncached(mp->m_ddev_targp, numblks, 0);
>  	if (!bp)
>  		return NULL;
>  
> @@ -345,7 +344,7 @@ xfs_ag_init_hdr(
>  {
>  	struct xfs_buf		*bp;
>  
> -	bp = xfs_get_aghdr_buf(mp, id->daddr, id->numblks, 0, ops);
> +	bp = xfs_get_aghdr_buf(mp, id->daddr, id->numblks, ops);
>  	if (!bp)
>  		return -ENOMEM;
>  
> 

-- 
Carlos



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux