Re: [PATCH v2] splice: only read in as much information as there is pipe buffer space

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Do., 5. Sept. 2019 um 05:42 Uhr schrieb Darrick J. Wong
<darrick.wong@xxxxxxxxxx>:
> On Fri, Aug 30, 2019 at 02:06:03PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> >
> > Andreas Grünbacher reports that on the two filesystems that support
> > iomap directio, it's possible for splice() to return -EAGAIN (instead of
> > a short splice) if the pipe being written to has less space available in
> > its pipe buffers than the length supplied by the calling process.
> >
> > Months ago we fixed splice_direct_to_actor to clamp the length of the
> > read request to the size of the splice pipe.  Do the same to do_splice.
> >
> > Fixes: 17614445576b6 ("splice: don't read more than available pipe space")
> > Reported-by: Andreas Grünbacher <andreas.gruenbacher@xxxxxxxxx>
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > ---
> > v2: tidy up the other call site per Andreas' request
>
> Ping?  Anyone want to add a RVB to this?

You can add the following:

Reviewed-by: Andreas Grünbacher <agruenba@xxxxxxxxxx>
Tested-by: Andreas Grünbacher <agruenba@xxxxxxxxxx>

And could you please update the email address in the reported-by tag as well?

Is this going to go in via the xfs tree?

Thanks,
Andreas




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux