Re: [PATCH 1/5] xfs_scrub: remove unnecessary fd parameter from file scrubbers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 05, 2019 at 08:33:28PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> xfs_scrub's scrub ioctl wrapper functions always take a scrub_ctx and an
> fd, but we always set the fd to ctx->mnt.fd.  Remove the redundant
> parameter.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
>  scrub/phase3.c |   10 +++++-----
>  scrub/scrub.c  |   34 ++++++++++++----------------------
>  scrub/scrub.h  |   16 ++++++++--------
>  3 files changed, 25 insertions(+), 35 deletions(-)

Nice little cleanup.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux