Re: [PATCH 04/10] man: document the new health reporting fields in various ioctls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/3/19 11:37 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Update the manpages to conver the new health reporting fields in the
> fs geometry, ag geometry, and bulkstat ioctls.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  man/man2/ioctl_xfs_ag_geometry.2   |   48 +++++++++++++++++++++++++++++++
>  man/man2/ioctl_xfs_fsbulkstat.2    |   52 +++++++++++++++++++++++++++++++++
>  man/man2/ioctl_xfs_fsop_geometry.2 |   56 +++++++++++++++++++++++++++++++++++-
>  3 files changed, 154 insertions(+), 2 deletions(-)
> 
> 
...

> diff --git a/man/man2/ioctl_xfs_fsbulkstat.2 b/man/man2/ioctl_xfs_fsbulkstat.2
> index a8b22dc4..3e13cfa8 100644
> --- a/man/man2/ioctl_xfs_fsbulkstat.2
> +++ b/man/man2/ioctl_xfs_fsbulkstat.2
> @@ -94,7 +94,9 @@ struct xfs_bstat {
>  	__u16             bs_projid_lo;
>  	__u16             bs_forkoff;
>  	__u16             bs_projid_hi;
> -	unsigned char     bs_pad[6];
> +	uint16_t          bs_sick;
> +	uint16_t          bs_checked;
> +	unsigned char     bs_pad[2];
>  	__u32             bs_cowextsize;
>  	__u32             bs_dmevmask;
>  	__u16             bs_dmstate;
> @@ -184,6 +186,54 @@ is unused on Linux.
>  .I bs_aextents
>  is the number of storage mappings associated with this file's extended
>  attributes.
> +.PP
> +The fields
> +.IR bs_sick " and " bs_checked
> +indicate the relative health of various allocation group metadata:


This should probably say "inode metadata?" 

I can fix that on the way in, the rest looks ok

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux