On Thu, Sep 05, 2019 at 03:42:10PM -0500, Goldwyn Rodrigues wrote: > > Thіs looks really strange. Can you explain me why you need the > > manual dirtying and SetPageUptodate, and an additional page refcount > > here? > > It was a part btrfs code which is carried forward. Yes, we don't need > the page dirtying and uptodate since iomap does it for us. But even the get_page seems very odd to me. It needs a detailed comment at least.