From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Remove the _ABORT code since nobody uses it and we're slowly moving to ECANCELED anyway. Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --- scrub/inodes.c | 2 +- scrub/inodes.h | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/scrub/inodes.c b/scrub/inodes.c index fea36773..ee4a52e3 100644 --- a/scrub/inodes.c +++ b/scrub/inodes.c @@ -180,7 +180,7 @@ scan_ag_inodes( _("Changed too many times during scan; giving up.")); break; } - case XFS_ITERATE_INODES_ABORT: + case ECANCELED: error = 0; /* fall thru */ default: diff --git a/scrub/inodes.h b/scrub/inodes.h index 5bedd55b..e3662c09 100644 --- a/scrub/inodes.h +++ b/scrub/inodes.h @@ -6,10 +6,16 @@ #ifndef XFS_SCRUB_INODES_H_ #define XFS_SCRUB_INODES_H_ +/* + * Return codes for the inode iterator function are 0 to continue iterating, + * and non-zero to stop iterating. Any non-zero value will be passed up to the + * iteration caller. The special value ECANCELED can be used to stop + * iteration, because the inode iteration function never generates that error + * code on its own. + */ typedef int (*scrub_inode_iter_fn)(struct scrub_ctx *ctx, struct xfs_handle *handle, struct xfs_bulkstat *bs, void *arg); -#define XFS_ITERATE_INODES_ABORT (-1) int scrub_scan_all_inodes(struct scrub_ctx *ctx, scrub_inode_iter_fn fn, void *arg);