On Tue, Sep 03, 2019 at 09:36:15PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Move this header to libfrog since the code is there already. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > db/info.c | 2 + > fsr/xfs_fsr.c | 2 + > growfs/xfs_growfs.c | 2 + > include/fsgeom.h | 102 --------------------------------------------------- > io/bmap.c | 2 + > io/fsmap.c | 2 + > io/imap.c | 2 + > io/open.c | 2 + > io/stat.c | 2 + > io/swapext.c | 2 + > libfrog/Makefile | 1 + > libfrog/fsgeom.h | 102 +++++++++++++++++++++++++++++++++++++++++++++++++++ > mkfs/xfs_mkfs.c | 2 + > quota/free.c | 2 + > quota/quot.c | 2 + > repair/xfs_repair.c | 2 + > rtcp/xfs_rtcp.c | 2 + > scrub/inodes.c | 2 + > scrub/phase1.c | 2 + > scrub/xfs_scrub.h | 2 + > spaceman/file.c | 2 + > spaceman/info.c | 2 + > 22 files changed, 122 insertions(+), 121 deletions(-) > delete mode 100644 include/fsgeom.h > create mode 100644 libfrog/fsgeom.h Looks good. One thing I noticed though: > diff --git a/libfrog/fsgeom.h b/libfrog/fsgeom.h > new file mode 100644 > index 00000000..6993dafb > --- /dev/null > +++ b/libfrog/fsgeom.h > @@ -0,0 +1,102 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2000-2005 Silicon Graphics, Inc. All Rights Reserved. This copyright is largely stale now. AFAICT, there's no original SGI code in this header file at all. Separate patch with a commit message explaining the copyright update? Otherwise looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
