On Tue, Sep 03, 2019 at 09:36:02PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Move this header to libfrog since the code is there already. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > include/bitmap.h | 24 ------------------------ > libfrog/Makefile | 1 + > libfrog/bitmap.h | 24 ++++++++++++++++++++++++ > repair/rmap.c | 2 +- > scrub/phase6.c | 2 +- > 5 files changed, 27 insertions(+), 26 deletions(-) > delete mode 100644 include/bitmap.h > create mode 100644 libfrog/bitmap.h looks good. FWIW, given these are file moves, you could tell git to generate move diffs rather than long form entire-file-changed diffs. The shortform git diffs are a lot easier to review :P Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx