On Mon, Sep 02, 2019 at 10:04:40AM -0700, Darrick J. Wong wrote: > On Mon, Sep 02, 2019 at 09:59:46AM +0200, Christoph Hellwig wrote: > > On Sun, Sep 01, 2019 at 01:31:40PM -0700, Darrick J. Wong wrote: > > > It's been mildly helpful for noticing when my online/offline repair > > > prototype code totally screws up, but at that point so much magic smoke > > > is already pouring out everywhere that it's hard not to notice. :) > > > > That suggests to just keep the macro as I submitted it, maybe with > > a big fat comment explaining the usage. > > Ok. Do you want to resubmit with a comment of your choosing, or let me > write in whatever: > > /* > * Check the mapping for obviously garbage allocations that could trash > * the filesystem immediately. > */ I was going to resend it, but now that you've written the comment for me feel free to just apply it with that added.