On Fri, Aug 30, 2019 at 12:24:10PM +0200, Christoph Hellwig wrote:
> This function isn't a macro anymore, so remove various superflous braces,
> and explicit cast that is done implicitly due to the return value, use
> a normal if statement instead of trying to squeeze everything together.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
--D
> ---
> fs/xfs/xfs_bmap_util.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
> index e12f0ba7f2eb..0910cb75b65d 100644
> --- a/fs/xfs/xfs_bmap_util.c
> +++ b/fs/xfs/xfs_bmap_util.c
> @@ -39,9 +39,9 @@
> xfs_daddr_t
> xfs_fsb_to_db(struct xfs_inode *ip, xfs_fsblock_t fsb)
> {
> - return (XFS_IS_REALTIME_INODE(ip) ? \
> - (xfs_daddr_t)XFS_FSB_TO_BB((ip)->i_mount, (fsb)) : \
> - XFS_FSB_TO_DADDR((ip)->i_mount, (fsb)));
> + if (XFS_IS_REALTIME_INODE(ip))
> + return XFS_FSB_TO_BB(ip->i_mount, fsb);
> + return XFS_FSB_TO_DADDR(ip->i_mount, fsb);
> }
>
> /*
> --
> 2.20.1
>
