On 8/29/19 3:26 AM, Christoph Hellwig wrote: > On Tue, Aug 27, 2019 at 02:17:36PM -0500, Eric Sandeen wrote: >> xfs_trans_log_buf() takes a final argument of the last byte to >> log in the buffer; b_length is in basic blocks, so this isn't >> the correct last byte. Fix it. >> >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> >> --- >> >> just found by inspection/pattern matching, not tested TBH... > > Looks good. And I wonder if we should fix the interface instead, > as it seems to lead to convoluted coe in just about every caller. Yup, I had considered that too. -Eric > Reviewed-by: Christoph Hellwig <hch@xxxxxx> >
