On Wed, 2019-08-28 at 08:34 -0500, Eric Sandeen wrote:
>
> On 8/28/19 8:29 AM, Brian Foster wrote:
> > > static struct file_system_type xfs_fs_type = {
> > > .owner = THIS_MODULE,
> > > .name = "xfs",
> > > - .mount = xfs_fs_mount,
> > > + .init_fs_context = xfs_init_fs_context,
> > > + .parameters = &xfs_fs_parameters,
> > Just a random observation.. we have a .name == "xfs" field here and
> > the
> > parameters struct has a .name == "XFS" field. Perhaps we should be
> > consistent?
> >
> > Brian
> >
>
> I sent a patch to fsdevel to just remove the .name from the new mount
> parameters
> structure; it's not had any attention yet. But I had the same
> concerns about
> consistency if we have to copy the same name to multiple places.
>
> [PATCH] fs: fs_parser: remove fs_parameter_description name field
I didn't see that yet (ha, I haven't really looked yet so no
surprize there), I'll add it to the series if David hasn't
got time to deal with it and see if we can get comments on it
later on in the process.
Ian
