Re: [PATCH v3 07/11] xfs: remove unlikely() from WARN_ON() condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 07/11] xfs: remove unlikely() from WARN_ON() condition
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 29 Aug 2019 22:37:20 -0700
Cc: linux-kernel@xxxxxxxxxxxxxxx, "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, Joe Perches <joe@xxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx
In-reply-to: <20190829165025.15750-7-efremov@linux.com>
References: <20190829165025.15750-1-efremov@linux.com> <20190829165025.15750-7-efremov@linux.com>
User-agent: Mutt/1.11.4 (2019-03-13)

On Thu, Aug 29, 2019 at 07:50:21PM +0300, Denis Efremov wrote:
> "unlikely(WARN_ON(x))" is excessive. WARN_ON() already uses unlikely()
> internally.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls
  - From: Denis Efremov
- [PATCH v3 07/11] xfs: remove unlikely() from WARN_ON() condition
  - From: Denis Efremov

Prev by Date: [PATCH] xfs: Initialize label array properly
Next by Date: Re: [PATCH 01/12] libxfs-diff: try harder to find the kernel equivalent libxfs files
Previous by thread: Re: [PATCH v3 07/11] xfs: remove unlikely() from WARN_ON() condition
Next by thread: Re: [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]

Powered by Linux