On 8/27/19 10:10 AM, Darrick J. Wong wrote: >> Eric's comments aside, it would be nice to have some consistency between >> the various result.negated checks (i.e. 'if (negated)' vs 'if >> (!negated)'). > Frankly I'd prefer "if (result.enabled)" or something affirmative so I > don't have to twist my brain around !negated == MAIN SCREEN TURN ON. > > --D I think it's probably possible to just keep explicit Opt_ikeep / Opt_noikeep and dispense with the whole negated/enabled parsing, unless there's a downside to doing that. Not quite sure what's best, but it also exposes the inconsistency we have with flag-ish options - some have negation of defaults as well as ability to restate defaults, others don't. (i.e. we have nouuid but not "uuid," norecovery but not "recovery," but we have ikeep/noikeep, attr2/noattr2...) -Eric
