On Mon, Aug 26, 2019 at 02:49:46PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > In xfs_rmap_irec_offset_unpack, we should always clear the contents of > rm_flags before we begin unpacking the encoded (ondisk) offset into the > incore rm_offset and incore rm_flags fields. Remove the open-coded > field zeroing as this encourages api misuse. Makes sense. Flags are meaningless until they've been extracted. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx