Re: [PATCH 2/5] xfs: remove unnecessary int returns from deferred rmap functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 26, 2019 at 02:49:27PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Remove the return value from the functions that schedule deferred rmap
> operations since they never fail and do not return status.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
>  fs/xfs/libxfs/xfs_bmap.c     |   36 ++++++++++++------------------------
>  fs/xfs/libxfs/xfs_refcount.c |    9 +++------
>  fs/xfs/libxfs/xfs_rmap.c     |   33 ++++++++++++++++-----------------
>  fs/xfs/libxfs/xfs_rmap.h     |   10 +++++-----
>  4 files changed, 36 insertions(+), 52 deletions(-)

Amazing how much gunk a bit of unnecessary error checking adds...
Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux